Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 解决用户在插入链接时，如果没有填写链接地址，无法自定义给出错误提示的问题 #5820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 解决用户在插入链接时，如果没有填写链接地址，无法自定义给出错误提示的问题 #5820

wants to merge 1 commit into from

Conversation

hexin333
Copy link

@hexin333 hexin333 commented Apr 2, 2024

问题复现步骤：
1.给insertLink加上自定义校验函数checkLink，在不输入链接地址时，函数无法触发

查看源码后发现，代码检测到没有url时，直接就return了，不会执行自定义校验函数，故改变代码执行顺序

@cycleccc cycleccc mentioned this pull request Jul 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cycleccc cycleccc cycleccc approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hexin333 @cycleccc